R-JunmingChen commented on code in PR #35356:
URL: https://github.com/apache/arrow/pull/35356#discussion_r1262002214
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -1755,6 +1755,20 @@ def test_logical():
assert pc.invert(a) == pa.array([False, True, True, None])
+def test_dictionary_decode():
+ array = pa.array(["a", "a", "b", "c", "b"])
+ dictionary_array = array.dictionary_encode()
+ dictionary_array_decode = dictionary_array.dictionary_decode()
+
+ assert array != dictionary_array
+
+ assert array == dictionary_array_decode
+ assert array == pc.dictionary_decode(dictionary_array)
+
+ with pytest.raises(TypeError):
+ pc.dictionary_decode(array)
Review Comment:
Good Catch. I also check the input type in python code, let me remove the
check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
