R-JunmingChen commented on code in PR #35356:
URL: https://github.com/apache/arrow/pull/35356#discussion_r1262007282
##########
python/pyarrow/array.pxi:
##########
@@ -2542,8 +2542,14 @@ cdef class DictionaryArray(Array):
def dictionary_decode(self):
"""
Decodes the DictionaryArray to an Array.
+
+ See :func:`pyarrow.compute.dictionary_decode` for usage.
+
+ Returns
+ -------
+ dictionary_decode : Array
"""
- return self.dictionary.take(self.indices)
+ return _pc().dictionary_decode(self)
Review Comment:
The old approach works well. I am not sure the entire risk of subtle
differences. One difference is that we output the original input if the input
is not dictionary_array. I think it's good to unify the dictionay_decode logic
in Python. But your consideration make senses, the change has a risk affecting
users who used the old dictionary_decode.
I roll back to old code currently, but I think we need further consideration
on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
