R-JunmingChen commented on code in PR #35356:
URL: https://github.com/apache/arrow/pull/35356#discussion_r1262007282
##########
python/pyarrow/array.pxi:
##########
@@ -2542,8 +2542,14 @@ cdef class DictionaryArray(Array):
def dictionary_decode(self):
"""
Decodes the DictionaryArray to an Array.
+
+ See :func:`pyarrow.compute.dictionary_decode` for usage.
+
+ Returns
+ -------
+ dictionary_decode : Array
"""
- return self.dictionary.take(self.indices)
+ return _pc().dictionary_decode(self)
Review Comment:
The old approach works well. I am not sure the risk of subtle differences. I
think it's good to unify the dictionay_decode in Python. But your
consideration make senses, the change has a risk affecting users who used the
old dictionary_decode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
