felipecrv commented on code in PR #36740:
URL: https://github.com/apache/arrow/pull/36740#discussion_r1266986372
##########
cpp/src/arrow/compute/kernels/ree_util_internal.cc:
##########
@@ -60,6 +60,7 @@ Result<std::shared_ptr<ArrayData>> PreallocateRunEndsArray(
Result<std::shared_ptr<ArrayData>> PreallocateValuesArray(
const std::shared_ptr<DataType>& value_type, bool has_validity_buffer,
int64_t length,
int64_t null_count, MemoryPool* pool, int64_t data_buffer_size) {
+ DCHECK(!has_validity_buffer || null_count != 0);
Review Comment:
I'm removing `null_count` instead and having the callers change the
`null_count`s from `kUnknownNullCount` to the correct value when they see fit.
Seems like a more robust way to guarantee correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
