kou commented on code in PR #36740:
URL: https://github.com/apache/arrow/pull/36740#discussion_r1266390979
##########
cpp/src/arrow/compute/kernels/ree_util_internal.cc:
##########
@@ -79,7 +80,10 @@ Result<std::shared_ptr<ArrayData>> PreallocateValuesArray(
} else {
values_data_buffers = {std::move(validity_buffer),
std::move(values_buffer)};
}
- return ArrayData::Make(value_type, length, std::move(values_data_buffers),
null_count);
+ auto data =
+ ArrayData::Make(value_type, length, std::move(values_data_buffers),
null_count);
+ DCHECK(!has_validity_buffer || data->buffers[0] != NULLPTR);
Review Comment:
We don't need to use `NULLPTR` in `.cc`.
And how about using this style?
```suggestion
DCHECK(!(has_validity_buffer && data->buffers[0]));
```
(Post-condition as a comment will help us here too.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
