felipecrv commented on code in PR #36740:
URL: https://github.com/apache/arrow/pull/36740#discussion_r1268210507
##########
cpp/src/arrow/compute/kernels/vector_run_end_encode.cc:
##########
@@ -398,17 +409,19 @@ class RunEndDecodeImpl {
}
}
- ARROW_ASSIGN_OR_RAISE(auto output_array_data,
- ree_util::PreallocateValuesArray(
- ree_type->value_type(), has_validity_buffer,
length,
- kUnknownNullCount, ctx_->memory_pool(),
data_buffer_size));
+ ARROW_ASSIGN_OR_RAISE(
+ auto output_array_data,
+ ree_util::PreallocateValuesArray(ree_type->value_type(),
has_validity_buffer,
+ length, ctx_->memory_pool(),
data_buffer_size));
int64_t output_null_count = 0;
if (length > 0) {
RunEndDecodingLoop<RunEndType, ValueType, has_validity_buffer> loop(
input_array_, output_array_data.get());
output_null_count = length - loop.ExpandAllRuns();
}
+ DCHECK(output_array_data->null_count == kUnknownNullCount ||
+ output_array_data->null_count == 0);
Review Comment:
Same as above. I'm removing the DCHECK to reduce the noise here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
