tustvold commented on code in PR #4561:
URL: https://github.com/apache/arrow-rs/pull/4561#discussion_r1271311991
##########
arrow-schema/src/datatype.rs:
##########
@@ -576,6 +576,11 @@ impl DataType {
_ => self == other,
}
}
+
+ /// Create a List DataType default name is "item"
+ pub fn new_list(data_type: DataType, nullable: bool) -> Self {
Review Comment:
I think for consistency with `Field::new_list` we should take the item name
as an argument. Thoughts @alamb ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
