alamb commented on code in PR #4561:
URL: https://github.com/apache/arrow-rs/pull/4561#discussion_r1271316616
##########
arrow-schema/src/datatype.rs:
##########
@@ -576,6 +576,11 @@ impl DataType {
_ => self == other,
}
}
+
+ /// Create a List DataType default name is "item"
+ pub fn new_list(data_type: DataType, nullable: bool) -> Self {
Review Comment:
I personally think we should use the standard / convention "item" always
(not take a new parameter) to encourage people to follow the convention. If
people want a different name, they can construct the DataType directly.
In terms of consistency with,
https://docs.rs/arrow/latest/arrow/datatypes/struct.Field.html#method.new_list
I would recommend we remove the name parameter from that method, due to the
same rationale above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
