sgilmore10 opened a new pull request, #36871:
URL: https://github.com/apache/arrow/pull/36871
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
The `arrow.type.TimestampType` display should include the `TimeUnit` and
`TimeZone` properties. Right now we only display the `ID` property:
```matlab
>> type = arrow.type.timestamp(TimeUnit="Second",
TimeZone="America/Anchorage")
type =
TimestampType with properties:
ID: Timestamp
```
We should show the other two properties in the display.
### What changes are included in this PR?
Modified the display of `TimestampType`:
```matlab
>> type = arrow.type.timestamp(TimeUnit="Second",
TimeZone="America/Anchorage")
type =
TimestampType with properties:
ID: Timestamp
TimeUnit: Second
TimeZone: "America/Anchorage"
```
Now `TimeUnit` and `TimeZone` are included.
### Are these changes tested?
Added a test case to `tTimestampType` called `Display`. It verifies
`TimestampType` objects are displayed correctly in the Command Window.
### Are there any user-facing changes?
Yes, users will see the new display.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
