kou commented on code in PR #36871:
URL: https://github.com/apache/arrow/pull/36871#discussion_r1274287725
##########
matlab/src/matlab/+arrow/+type/TimestampType.m:
##########
@@ -39,4 +39,11 @@
tz = obj.Proxy.timeZone();
end
end
+
+ methods (Access=protected)
+ function propgrp = getPropertyGroups(~)
+ proplist = {'ID', 'TimeUnit', 'TimeZone'};
+ propgrp = matlab.mixin.util.PropertyGroup(proplist);
Review Comment:
Can we improve naming? e.g.:
```suggestion
function groups = getPropertyGroups(~)
targets = {'ID', 'TimeUnit', 'TimeZone'};
groups = matlab.mixin.util.PropertyGroup(targets);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
