kevingurney commented on code in PR #36871:
URL: https://github.com/apache/arrow/pull/36871#discussion_r1275101610
##########
matlab/src/matlab/+arrow/+type/TimestampType.m:
##########
@@ -39,4 +39,11 @@
tz = obj.Proxy.timeZone();
end
end
+
+ methods (Access=protected)
+ function groups = getPropertyGroups(~)
+ targets = {'ID', 'TimeUnit', 'TimeZone'};
Review Comment:
Can this be a `string` array rather than a `cellstr`?
##########
matlab/test/arrow/type/tTimestampType.m:
##########
@@ -105,5 +105,28 @@ function ErrorIfTimeUnitIsNonScalar(testCase)
fcn = @() arrow.type.timestamp(TimeZone=units);
testCase.verifyError(fcn, "MATLAB:validation:IncompatibleSize");
end
+
+ function Display(testCase)
+ % Verify the display of TimestampType objects.
+ %
+ % Example:
+ %
+ % TimestampType with properties:
+ %
+ % ID: Timestamp
+ % TimeUnit: Second
+ % TimeZone: "America/Anchorage"
+ %
+ type = arrow.type.timestamp(TimeUnit="Second",
TimeZone="America/Anchorage"); %#ok<NASGU>
+ classnameLink = '<a href="matlab:helpPopup
arrow.type.TimestampType" style="font-weight:bold">TimestampType</a>';
Review Comment:
Can this be a `string`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
