lidavidm commented on code in PR #948:
URL: https://github.com/apache/arrow-adbc/pull/948#discussion_r1278150611
##########
c/validation/adbc_validation.cc:
##########
@@ -1095,8 +1100,12 @@ void StatementTest::TestSqlIngestBinary() {
NANOARROW_TYPE_BINARY, {std::nullopt, "", "\x00\x01\x02\x04",
"\xFE\xFF"}));
}
+void StatementTest::TestSqlIngestDate32() {
+
ASSERT_NO_FATAL_FAILURE(TestSqlIngestNumericType<int32_t>(NANOARROW_TYPE_DATE32));
Review Comment:
What about something like this?
https://github.com/apache/arrow-adbc/issues/787
What I envision there is a set of directories, one per vendor, where each
has a `.sql` file that creates tables and inserts data and a reference `.arrow`
file for the expected output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
