WillAyd commented on code in PR #948:
URL: https://github.com/apache/arrow-adbc/pull/948#discussion_r1279805635
##########
c/validation/adbc_validation.cc:
##########
@@ -1037,6 +1037,10 @@ void StatementTest::TestSqlIngestNumericType(ArrowType
type) {
// values. Likely a bug on our side, but for now, avoid them.
values.push_back(static_cast<CType>(-1.5));
values.push_back(static_cast<CType>(1.5));
+ } else if (type == ArrowType::NANOARROW_TYPE_DATE32) {
+ // Windows does not seem to support negative date values
+ values.push_back(static_cast<CType>(0));
Review Comment:
Having to use 0 as a minimum value here is unfortunate. I couldn't find any
real documentation on gmtime_s limitations in Windows, except that the upper
limit on 64 bit systems is through the year 3000
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/gmtime-s-gmtime32-s-gmtime64-s?view=msvc-170
Guessing it may also just not support negative dates in a way that is
undocumented? Unfortunately I do not have a windows machine available to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
