WillAyd commented on code in PR #948:
URL: https://github.com/apache/arrow-adbc/pull/948#discussion_r1279434403
##########
c/validation/adbc_validation.cc:
##########
@@ -1095,8 +1100,12 @@ void StatementTest::TestSqlIngestBinary() {
NANOARROW_TYPE_BINARY, {std::nullopt, "", "\x00\x01\x02\x04",
"\xFE\xFF"}));
}
+void StatementTest::TestSqlIngestDate32() {
+
ASSERT_NO_FATAL_FAILURE(TestSqlIngestNumericType<int32_t>(NANOARROW_TYPE_DATE32));
Review Comment:
I think this makes sense. Before I go too deep - when looking at this I
figured we would have to vendor `nanoarrow_ipc`, which in turn would require us
to at flatcc. Does that make sense or am I overcomplicating?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
