liurenjie1024 commented on code in PR #4636:
URL: https://github.com/apache/arrow-rs/pull/4636#discussion_r1284489405


##########
parquet/src/file/metadata.rs:
##########
@@ -277,6 +277,9 @@ pub struct RowGroupMetaData {
     sorting_columns: Option<Vec<SortingColumn>>,
     total_byte_size: i64,
     schema_descr: SchemaDescPtr,
+    // We can't infer from file offset of first column since there may empty 
columns in row group.

Review Comment:
   Hmm, I think it safer to use unsigned value for in memory representation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to