tustvold commented on code in PR #4636:
URL: https://github.com/apache/arrow-rs/pull/4636#discussion_r1284547996
##########
parquet/src/file/metadata.rs:
##########
@@ -277,6 +277,9 @@ pub struct RowGroupMetaData {
sorting_columns: Option<Vec<SortingColumn>>,
total_byte_size: i64,
schema_descr: SchemaDescPtr,
+ // We can't infer from file offset of first column since there may empty
columns in row group.
Review Comment:
I would tend to agree, however, for consistency with the rest of the APIs
and with the parquet format I think this should be signed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
