tustvold commented on code in PR #4636:
URL: https://github.com/apache/arrow-rs/pull/4636#discussion_r1285687428
##########
parquet/src/file/writer.rs:
##########
@@ -418,16 +425,22 @@ impl<'a, W: Write + Send> SerializedRowGroupWriter<'a, W>
{
/// - `schema_descr` - the schema to write
/// - `properties` - writer properties
/// - `buf` - the buffer to write data to
+ /// - `row_group_index` - row group index in this parquet file.
+ /// - `file_offset` - file offset of this row group in this parquet file.
/// - `on_close` - an optional callback that will invoked on
[`Self::close`]
pub fn new(
schema_descr: SchemaDescPtr,
properties: WriterPropertiesPtr,
buf: &'a mut TrackedWrite<W>,
+ row_group_index: usize,
+ file_offset: usize,
Review Comment:
Instead of passing this in, could we just read this from `buf`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
