emkornfield commented on code in PR #36972:
URL: https://github.com/apache/arrow/pull/36972#discussion_r1285158200
##########
cpp/src/parquet/encoding.cc:
##########
@@ -365,7 +369,7 @@ class PlainEncoder<BooleanType> : public EncoderImpl,
virtual public BooleanEnco
}
writer.Finish();
}
- sink_.UnsafeAdvance(data.length());
+ sink_.UnsafeAdvance(data.length() - data.null_count());
Review Comment:
I was referring to the entire value passed into sink_.UnsafeAdvance
This seems like it was incorrect even for all present values because we are
advancing the Byte buffer by number of values (in this case these would be
number of bits) and not number bytes. So we would be overadvancing in both
cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
