emkornfield commented on code in PR #36972:
URL: https://github.com/apache/arrow/pull/36972#discussion_r1285160022


##########
cpp/src/parquet/encoding.cc:
##########
@@ -354,6 +357,7 @@ class PlainEncoder<BooleanType> : public EncoderImpl, 
virtual public BooleanEnco
                                                       sink_.length(), n_valid);

Review Comment:
   You mentioned this below, using sink_.length() to store the actual values 
seems wrong.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to