emkornfield commented on code in PR #36972:
URL: https://github.com/apache/arrow/pull/36972#discussion_r1285159943
##########
cpp/src/parquet/encoding.cc:
##########
@@ -365,7 +369,7 @@ class PlainEncoder<BooleanType> : public EncoderImpl,
virtual public BooleanEnco
}
writer.Finish();
}
- sink_.UnsafeAdvance(data.length());
+ sink_.UnsafeAdvance(data.length() - data.null_count());
Review Comment:
In that case we need to be reserving k bytes and not k/8. I think this
wasn't caught sooner because columnwriter appears to have a specialization for
Boolean values that bypasses this method (e.g. I don't think anything but
encoder tests will pass if you put `throw exception(....)` in this method in
general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
