MarcoGorelli commented on a change in pull request #9045:
URL: https://github.com/apache/arrow/pull/9045#discussion_r550428589



##########
File path: .pre-commit-config.yaml
##########
@@ -40,9 +40,10 @@ repos:
       - id: cmake-format
         name: CMake Format
         language: python
-        entry: bash -c "pip install cmake-format && python run-cmake-format.py 
--check"
-        entry: echo
-        files: ^(.*/CMakeLists.txt|.*.cmake)$
+        entry: cmake-format --in-place --autosort=false

Review comment:
       Also, like this, if you enable pre-commit (`pre-commit install`) then 
this'll run only on files you've staged, rather than on the wholecodebase each 
time (as it would if using `run-cmake-format.py`). You can still choose to run 
it on the whole codebase though, with `--all-files` (as in the example i posted 
above)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to