MarcoGorelli commented on a change in pull request #9045:
URL: https://github.com/apache/arrow/pull/9045#discussion_r550745036
##########
File path: .pre-commit-config.yaml
##########
@@ -40,9 +40,10 @@ repos:
- id: cmake-format
name: CMake Format
language: python
- entry: bash -c "pip install cmake-format && python run-cmake-format.py
--check"
- entry: echo
- files: ^(.*/CMakeLists.txt|.*.cmake)$
+ entry: cmake-format --in-place --autosort=false
Review comment:
:thinking: not sure why that would be, but point taken. Though there
would still be a difference if you run it as a git commit hook (i.e. if you've
done `pre-commit install` in your environment) because like this it'll only run
on staged files, while the Python script runs on all of them each time, so
this'll give faster feedback to devs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
