kou commented on a change in pull request #9045:
URL: https://github.com/apache/arrow/pull/9045#discussion_r550925323
##########
File path: .pre-commit-config.yaml
##########
@@ -40,9 +40,10 @@ repos:
- id: cmake-format
name: CMake Format
language: python
- entry: bash -c "pip install cmake-format && python run-cmake-format.py
--check"
- entry: echo
- files: ^(.*/CMakeLists.txt|.*.cmake)$
+ entry: cmake-format --in-place --autosort=false
Review comment:
It seems that `pre-commit` runs `cmake-format` for each target file.
But `run-cmake-format.py` runs one `cmake-format` for all target files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
