tustvold commented on code in PR #4701:
URL: https://github.com/apache/arrow-rs/pull/4701#discussion_r1294898073
##########
arrow-ord/Cargo.toml:
##########
@@ -44,10 +44,3 @@ half = { version = "2.1", default-features = false, features
= ["num-traits"] }
[dev-dependencies]
rand = { version = "0.8", default-features = false, features = ["std",
"std_rng"] }
-
-[package.metadata.docs.rs]
-features = ["dyn_cmp_dict"]
-
-[features]
-dyn_cmp_dict = []
-simd = ["arrow-array/simd"]
Review Comment:
The SIMD variants added a non-trivial amount of code complexity, and behaved
differently. I opted to simply remove them, we can always add back some sort of
SIMD specialization for primitives in future should users feel strongly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]