tustvold commented on code in PR #4701:
URL: https://github.com/apache/arrow-rs/pull/4701#discussion_r1295739681
##########
arrow/benches/equal.rs:
##########
@@ -49,11 +44,6 @@ fn add_benchmark(c: &mut Criterion) {
let arr_a = create_string_array::<i32>(512, 0.0);
c.bench_function("equal_string_512", |b| b.iter(|| bench_equal(&arr_a)));
- let arr_a = create_string_array::<i32>(512, 0.0);
Review Comment:
Because it didn't belong in a benchmark about ArrayData equality :smile:
It is better covered by comparison_kernels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
