tustvold commented on code in PR #4701:
URL: https://github.com/apache/arrow-rs/pull/4701#discussion_r1295738994
##########
arrow-ord/Cargo.toml:
##########
@@ -44,10 +44,3 @@ half = { version = "2.1", default-features = false, features
= ["num-traits"] }
[dev-dependencies]
rand = { version = "0.8", default-features = false, features = ["std",
"std_rng"] }
-
-[package.metadata.docs.rs]
-features = ["dyn_cmp_dict"]
-
-[features]
-dyn_cmp_dict = []
-simd = ["arrow-array/simd"]
Review Comment:
It is empirically not the case here, LLVM is really bad at optimising
horizontal operations such as creating a packed bitmask from a comparison. The
LLVM generated kernels are ~2x slower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
