mapleFU commented on code in PR #37360:
URL: https://github.com/apache/arrow/pull/37360#discussion_r1305290064
##########
cpp/src/arrow/io/memory.h:
##########
@@ -146,13 +146,23 @@ class ARROW_EXPORT BufferReader
: public internal::RandomAccessFileConcurrencyWrapper<BufferReader> {
public:
explicit BufferReader(std::shared_ptr<Buffer> buffer);
+ ARROW_DEPRECATED(
+ "Deprecated in 14.0.0. Use FromString or
BufferReader(std::shared_ptr<Buffer> "
+ "buffer) instead.")
explicit BufferReader(const Buffer& buffer);
+ ARROW_DEPRECATED(
+ "Deprecated in 14.0.0. Use FromString or
BufferReader(std::shared_ptr<Buffer> "
+ "buffer) instead.")
BufferReader(const uint8_t* data, int64_t size);
- /// \brief Instantiate from std::string or std::string_view. Does not
- /// own data
+ /// \brief Instantiate from std::string_view. Does not own data
+ ARROW_DEPRECATED(
+ "Deprecated in 14.0.0. Use FromString or
BufferReader(std::shared_ptr<Buffer> "
+ "buffer) instead.")
explicit BufferReader(std::string_view data);
+ static std::unique_ptr<BufferReader> FromString(std::string data);
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
