mapleFU commented on code in PR #37360:
URL: https://github.com/apache/arrow/pull/37360#discussion_r1307653178
##########
cpp/src/arrow/compute/function_internal.cc:
##########
@@ -83,7 +83,8 @@ Result<std::unique_ptr<FunctionOptions>>
GenericOptionsType::Deserialize(
Result<std::unique_ptr<FunctionOptions>> DeserializeFunctionOptions(
const Buffer& buffer) {
- io::BufferReader stream(buffer);
+ // Create a non-owned Buffer to avoid copying
Review Comment:
I've changed to `BufferReader::FromString`, though other way might be better
but I think `FunctionOptions` would not be too large, so maybe `FromString` it
is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
