mapleFU commented on code in PR #37360:
URL: https://github.com/apache/arrow/pull/37360#discussion_r1307439474
##########
cpp/src/arrow/flight/sql/client.cc:
##########
@@ -519,13 +519,17 @@ arrow::Result<std::shared_ptr<PreparedStatement>>
PreparedStatement::ParseRespon
std::shared_ptr<Schema> dataset_schema;
if (!serialized_dataset_schema.empty()) {
- io::BufferReader dataset_schema_reader(serialized_dataset_schema);
+ // Create a non-owned Buffer to avoid copying
Review Comment:
@lidavidm do you think this is ok? Seems it only return `ReadSchema` here, I
think just keep zero-copy is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
