davisusanibar commented on code in PR #35570:
URL: https://github.com/apache/arrow/pull/35570#discussion_r1307635080
##########
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanOptions.java:
##########
@@ -58,6 +60,18 @@ public ScanOptions(long batchSize, Optional<String[]>
columns) {
this.columns = columns;
}
+ /**
+ * Constructor.
+ * @param batchSize Maximum row number of each returned {@link
org.apache.arrow.vector.ipc.message.ArrowRecordBatch}
+ * @param substraitExtendedExpression Extended expression to evaluate for
project new columns or apply filter.
+ */
+ public ScanOptions(long batchSize, ByteBuffer substraitExtendedExpression) {
Review Comment:
added
##########
java/dataset/src/main/java/org/apache/arrow/dataset/source/Dataset.java:
##########
@@ -32,4 +32,14 @@ public interface Dataset extends AutoCloseable {
* @return the Scanner instance
*/
Scanner newScan(ScanOptions options);
+
+ /**
+ * Create a new Scanner, using the provided options,
+ * that contains the binary representation of the Substrait
+ * Extended Expression.
+ *
+ * @param options options used during creating Scanner
+ * @return the Scanner instance
+ */
+ Scanner newSubstraitScan(ScanOptions options);
Review Comment:
changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
