davisusanibar commented on code in PR #35570:
URL: https://github.com/apache/arrow/pull/35570#discussion_r1312995725
##########
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanOptions.java:
##########
@@ -27,6 +28,9 @@
public class ScanOptions {
private final Optional<String[]> columns;
private final long batchSize;
+ private ByteBuffer projection;
+ private ByteBuffer filter;
Review Comment:
Changed
##########
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanOptions.java:
##########
@@ -69,4 +73,106 @@ public Optional<String[]> getColumns() {
public long getBatchSize() {
return batchSize;
}
+
+ private ByteBuffer getProjection() {
Review Comment:
Changed
##########
java/dataset/src/main/cpp/jni_wrapper.cc:
##########
@@ -458,8 +467,8 @@ JNIEXPORT void JNICALL
Java_org_apache_arrow_dataset_jni_JniWrapper_closeDataset
* Signature: (J[Ljava/lang/String;JJ)J
*/
JNIEXPORT jlong JNICALL
Java_org_apache_arrow_dataset_jni_JniWrapper_createScanner(
- JNIEnv* env, jobject, jlong dataset_id, jobjectArray columns, jlong
batch_size,
- jlong memory_pool_id) {
+ JNIEnv* env, jobject, jlong dataset_id, jobjectArray columns,
+ jobject substrait_extended_expression, jlong batch_size, jlong
memory_pool_id) {
Review Comment:
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
