davisusanibar commented on code in PR #35570:
URL: https://github.com/apache/arrow/pull/35570#discussion_r1312181710
##########
java/dataset/src/main/cpp/jni_wrapper.cc:
##########
@@ -458,8 +467,8 @@ JNIEXPORT void JNICALL
Java_org_apache_arrow_dataset_jni_JniWrapper_closeDataset
* Signature: (J[Ljava/lang/String;JJ)J
*/
JNIEXPORT jlong JNICALL
Java_org_apache_arrow_dataset_jni_JniWrapper_createScanner(
- JNIEnv* env, jobject, jlong dataset_id, jobjectArray columns, jlong
batch_size,
- jlong memory_pool_id) {
+ JNIEnv* env, jobject, jlong dataset_id, jobjectArray columns,
+ jobject substrait_extended_expression, jlong batch_size, jlong
memory_pool_id) {
Review Comment:
It is possible to do that. It may be necessary to invoke Cpp twice to get
bounded expressions, once for each filter and once for each projection. What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
