sunchao opened a new pull request, #7494:
URL: https://github.com/apache/arrow-datafusion/pull/7494
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #7493.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Currently `PrimitiveGroupsAccumulator#evaluate` method initialize the result
Arrow array using its generic type parameter `T` which is a
`ArrowPrimitiveType`, which is converted from a enum `DataType`. This, however,
doesn't have complete information comparing to the original `DataType` it
converted from. For instance, `TimestampMicrosecondType` always have `None` as
timezone while in the `DataType` it could be set to some specific timezone.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
I noticed that we already have `adjust_output_array` that handles a similar
case for decimal type. One straightforward solution is to add another case for
`Timestamp` in the method. However, I feel the logic would become simpler if we
just call `with_data_type` after creating the Arrow array. This would also
allow us to prevent more potential issues in the future. Therefore, in this PR
I replaced all usage of `adjust_output_array` with `with_data_type` and removed
the method itself.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Added some new tests for this.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
