sunchao commented on code in PR #7494:
URL: https://github.com/apache/arrow-datafusion/pull/7494#discussion_r1318911032
##########
datafusion/physical-expr/src/expressions/mod.rs:
##########
@@ -136,6 +137,35 @@ pub(crate) mod tests {
}};
}
+ /// macro to perform an aggregation using [`GroupsAccumulator`] and verify
the result.
Review Comment:
Let me add some comments here. I don't really like the name
`generic_test_op_new` too.
The current `generic_test_op` only test the old slow-path `Accumulator`. In
order to test this change which happens to the new `GroupsAccumulator`, I have
to create a new similar macro that calls `GroupsAccumulator`'s `update_batch`
and `evaluate` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
