alamb commented on code in PR #7494:
URL: https://github.com/apache/arrow-datafusion/pull/7494#discussion_r1318897372
##########
datafusion/physical-expr/src/expressions/mod.rs:
##########
@@ -136,6 +137,35 @@ pub(crate) mod tests {
}};
}
+ /// macro to perform an aggregation using [`GroupsAccumulator`] and verify
the result.
Review Comment:
Perhaps it would help here to explain the difference between
`generic_test_op` and `generic_test_op_new`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
