suremarc commented on code in PR #4797:
URL: https://github.com/apache/arrow-rs/pull/4797#discussion_r1319976782
##########
arrow-flight/src/sql/server.rs:
##########
@@ -366,7 +366,7 @@ pub trait FlightSqlService: Sync + Send + Sized + 'static {
/// Implementors may override to handle additional calls to do_put()
async fn do_put_fallback(
&self,
- _request: Request<Streaming<FlightData>>,
+ _request: Request<Peekable<Streaming<FlightData>>>,
Review Comment:
It's a tough decision for me. I prefer using `Peekable` as it can be used as
if it were the original stream, but I hate the fact that we have to leak its
usage. We could pass the first `FlightData` as a separate argument, but it
would require the user to `chain` it with the stream, if they wanted to use any
APIs expecting a stream of FlightData. So I think I would stick with `Peekable`
in the absence of any preference from others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
