suremarc commented on code in PR #4797:
URL: https://github.com/apache/arrow-rs/pull/4797#discussion_r1327742857
##########
arrow-flight/src/sql/server.rs:
##########
@@ -366,7 +366,7 @@ pub trait FlightSqlService: Sync + Send + Sized + 'static {
/// Implementors may override to handle additional calls to do_put()
async fn do_put_fallback(
&self,
- _request: Request<Streaming<FlightData>>,
+ _request: Request<Peekable<Streaming<FlightData>>>,
Review Comment:
I added a new type, `PeekableFlightDataStream`, which exposes `into_inner`
and `peek`, similarly to `Peekable`. I think this is a good enough subset of
functionality for FlightSQL use cases, and if users need access to more of the
lower-level functionality of `Peekable`, they can call
`PeekableFlightDataStream::into_peekable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
