suremarc commented on code in PR #4797:
URL: https://github.com/apache/arrow-rs/pull/4797#discussion_r1320032137
##########
arrow-flight/src/sql/client.rs:
##########
@@ -451,7 +456,9 @@ impl PreparedStatement<Channel> {
/// Executes the prepared statement update query on the server.
pub async fn execute_update(&mut self) -> Result<i64, ArrowError> {
- let cmd = CommandPreparedStatementQuery {
+ self.write_bind_params().await?;
+
+ let cmd = CommandPreparedStatementUpdate {
Review Comment:
I also forgot to mention, I think this was a bug in the existing
implementation. `ExecuteUpdate` should be performed with a
`CommandPreparedStatementUpdate` command, not a
`CommandPreparedStatementQuery`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
