assignUser commented on code in PR #37637:
URL: https://github.com/apache/arrow/pull/37637#discussion_r1320394441
##########
.github/workflows/go.yml:
##########
@@ -288,12 +288,12 @@ jobs:
strategy:
fail-fast: false
matrix:
- go: [1.17, 1.18]
+ go: [1.19, '1.20']
include:
Review Comment:
These include bits are not really necessary, we can just add static check as
another matrix element as we want to check all the combinations (2 versions of
go each with the same static check). So there is no need to explicitly list the
combinations.
##########
.github/workflows/go.yml:
##########
@@ -288,12 +288,12 @@ jobs:
strategy:
fail-fast: false
matrix:
- go: [1.17, 1.18]
+ go: [1.19, '1.20']
include:
Review Comment:
(or read staticcheck version from env as kou suggested and just have the go
array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
