kou commented on code in PR #37637:
URL: https://github.com/apache/arrow/pull/37637#discussion_r1322235573
##########
.github/workflows/go.yml:
##########
@@ -208,15 +199,10 @@ jobs:
strategy:
fail-fast: false
matrix:
- go: [1.17, 1.18]
- include:
- - go: 1.17
- staticcheck: v0.2.2
- - go: 1.18
- staticcheck: v0.3.3
+ go: [1.19, '1.20']
env:
GO: ${{ matrix.go }}
- STATICCHECK: ${{ matrix.staticcheck }}
+ STATICCHECK: v0.4.5
Review Comment:
ditto.
##########
.github/workflows/go.yml:
##########
@@ -161,15 +157,10 @@ jobs:
strategy:
fail-fast: false
matrix:
- go: [1.17, 1.18]
- include:
- - go: 1.17
- staticcheck: v0.2.2
- - go: 1.18
- staticcheck: v0.3.3
+ go: [1.19, '1.20']
env:
GO: ${{ matrix.go }}
- STATICCHECK: ${{ matrix.staticcheck }}
+ STATICCHECK: v0.4.5
Review Comment:
ditto.
##########
.github/workflows/go.yml:
##########
@@ -272,7 +253,9 @@ jobs:
cache: true
cache-dependency-path: go/go.sum
- name: Install staticcheck
- run: go install honnef.co/go/tools/cmd/staticcheck@${{
matrix.staticcheck }}
+ run: |
Review Comment:
```suggestion
shell: bash
run: |
```
##########
.github/workflows/go.yml:
##########
@@ -430,11 +407,13 @@ jobs:
- name: Install go
uses: actions/setup-go@v4
with:
- go-version: '1.18'
+ go-version: '1.19'
cache: true
cache-dependency-path: go/go.sum
- name: Install staticcheck
- run: go install honnef.co/go/tools/cmd/[email protected]
+ run: |
Review Comment:
```suggestion
shell: bash
run: |
```
##########
.github/workflows/go.yml:
##########
@@ -54,28 +54,24 @@ jobs:
include:
- arch-label: AMD64
arch: amd64
- go: 1.17
- runs-on: ubuntu-latest
- staticcheck: v0.2.2
+ go: 1.19
+ runs-on: ubuntu-latest
- arch-label: AMD64
arch: amd64
- go: 1.18
- runs-on: ubuntu-latest
- staticcheck: v0.3.3
+ go: '1.20'
+ runs-on: ubuntu-latest
- arch-label: ARM64
arch: arm64v8
- go: 1.17
- staticcheck: v0.2.2
+ go: 1.19
runs-on: ["self-hosted", "arm", "linux"]
- arch-label: ARM64
arch: arm64v8
- go: 1.18
- staticcheck: v0.3.3
+ go: '1.20'
runs-on: ["self-hosted", "arm", "linux"]
env:
ARCH: ${{ matrix.arch }}
GO: ${{ matrix.go }}
- STATICCHECK: ${{ matrix.staticcheck }}
+ STATICCHECK: v0.4.5
Review Comment:
I think that we can remove this because `archery docker run` reads `.env`
automatically and we have `STATICCHECK=v0.4.5` in `.env`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
