kou commented on code in PR #37637:
URL: https://github.com/apache/arrow/pull/37637#discussion_r1323787026
##########
.github/workflows/go.yml:
##########
@@ -54,28 +54,23 @@ jobs:
include:
- arch-label: AMD64
arch: amd64
- go: 1.17
- runs-on: ubuntu-latest
- staticcheck: v0.2.2
+ go: 1.19
+ runs-on: ubuntu-latest
Review Comment:
```suggestion
runs-on: ubuntu-latest
```
##########
.github/workflows/go.yml:
##########
@@ -54,28 +54,23 @@ jobs:
include:
- arch-label: AMD64
arch: amd64
- go: 1.17
- runs-on: ubuntu-latest
- staticcheck: v0.2.2
+ go: 1.19
+ runs-on: ubuntu-latest
- arch-label: AMD64
arch: amd64
- go: 1.18
- runs-on: ubuntu-latest
- staticcheck: v0.3.3
+ go: '1.20'
+ runs-on: ubuntu-latest
- arch-label: ARM64
arch: arm64v8
- go: 1.17
- staticcheck: v0.2.2
+ go: 1.19
runs-on: ["self-hosted", "arm", "linux"]
- arch-label: ARM64
arch: arm64v8
- go: 1.18
- staticcheck: v0.3.3
+ go: '1.20'
runs-on: ["self-hosted", "arm", "linux"]
env:
ARCH: ${{ matrix.arch }}
- GO: ${{ matrix.go }}
- STATICCHECK: ${{ matrix.staticcheck }}
+ GO: ${{ matrix.go }}
Review Comment:
```suggestion
GO: ${{ matrix.go }}
```
##########
.github/workflows/go.yml:
##########
@@ -54,28 +54,23 @@ jobs:
include:
- arch-label: AMD64
arch: amd64
- go: 1.17
- runs-on: ubuntu-latest
- staticcheck: v0.2.2
+ go: 1.19
+ runs-on: ubuntu-latest
- arch-label: AMD64
arch: amd64
- go: 1.18
- runs-on: ubuntu-latest
- staticcheck: v0.3.3
+ go: '1.20'
+ runs-on: ubuntu-latest
- arch-label: ARM64
arch: arm64v8
- go: 1.17
- staticcheck: v0.2.2
+ go: 1.19
runs-on: ["self-hosted", "arm", "linux"]
- arch-label: ARM64
arch: arm64v8
- go: 1.18
- staticcheck: v0.3.3
+ go: '1.20'
Review Comment:
```suggestion
go: '1.20'
```
##########
.github/workflows/go.yml:
##########
@@ -54,28 +54,23 @@ jobs:
include:
- arch-label: AMD64
arch: amd64
- go: 1.17
- runs-on: ubuntu-latest
- staticcheck: v0.2.2
+ go: 1.19
+ runs-on: ubuntu-latest
- arch-label: AMD64
arch: amd64
- go: 1.18
- runs-on: ubuntu-latest
- staticcheck: v0.3.3
+ go: '1.20'
+ runs-on: ubuntu-latest
- arch-label: ARM64
arch: arm64v8
- go: 1.17
- staticcheck: v0.2.2
+ go: 1.19
Review Comment:
```suggestion
go: 1.19
```
##########
.github/workflows/go.yml:
##########
@@ -161,15 +156,9 @@ jobs:
strategy:
fail-fast: false
matrix:
- go: [1.17, 1.18]
- include:
- - go: 1.17
- staticcheck: v0.2.2
- - go: 1.18
- staticcheck: v0.3.3
+ go: [1.19, '1.20']
Review Comment:
```suggestion
go: [1.19, '1.20']
```
##########
.github/workflows/go.yml:
##########
@@ -161,15 +156,9 @@ jobs:
strategy:
fail-fast: false
matrix:
- go: [1.17, 1.18]
- include:
- - go: 1.17
- staticcheck: v0.2.2
- - go: 1.18
- staticcheck: v0.3.3
+ go: [1.19, '1.20']
env:
- GO: ${{ matrix.go }}
- STATICCHECK: ${{ matrix.staticcheck }}
+ GO: ${{ matrix.go }}
Review Comment:
```suggestion
GO: ${{ matrix.go }}
```
##########
.github/workflows/go.yml:
##########
@@ -54,28 +54,23 @@ jobs:
include:
- arch-label: AMD64
arch: amd64
- go: 1.17
- runs-on: ubuntu-latest
- staticcheck: v0.2.2
+ go: 1.19
+ runs-on: ubuntu-latest
- arch-label: AMD64
arch: amd64
- go: 1.18
- runs-on: ubuntu-latest
- staticcheck: v0.3.3
+ go: '1.20'
+ runs-on: ubuntu-latest
Review Comment:
```suggestion
runs-on: ubuntu-latest
```
##########
.github/workflows/go.yml:
##########
@@ -208,15 +197,9 @@ jobs:
strategy:
fail-fast: false
matrix:
- go: [1.17, 1.18]
- include:
- - go: 1.17
- staticcheck: v0.2.2
- - go: 1.18
- staticcheck: v0.3.3
+ go: [1.19, '1.20']
Review Comment:
```suggestion
go: [1.19, '1.20']
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
