viirya opened a new pull request, #7565:
URL: https://github.com/apache/arrow-datafusion/pull/7565
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
First and Last Accumulators would update itself from first/last row during
merging state batches (e.g., `merge_batch`). However, currently it takes the
whole state row (which includes `is_set` flag) into `update_with_new_row` which
in turn takes all columns except for first one into `orderings` (so existing
`is_set` is put there) and adds `is_set` flag. This ends with double `is_set`
flags if `state` is called on the accumulators which have merged state batches.
Normally this is not an issue because `state` is not called once aggregation
enters the stage of merging state batches. But in #7400, where spilling happens
to call `state` on such accumulators to get its states and spill into disk.
This leads to a hacky fix there and we should fix these two accumulators
accordingly to avoid the hacky way.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
