kazuyukitanimura commented on code in PR #7565:
URL: https://github.com/apache/arrow-datafusion/pull/7565#discussion_r1327686711
##########
datafusion/physical-expr/src/aggregate/first_last.rs:
##########
@@ -237,13 +231,17 @@ impl Accumulator for FirstValueAccumulator {
};
if !ordered_states[0].is_empty() {
let first_row = get_row_at_idx(&ordered_states, 0)?;
- let first_ordering = &first_row[1..];
+ // When collecting orderings, we exclude the is_set flag from the
state.
+ let first_ordering = &first_row[1..is_set_idx];
Review Comment:
`is_set_idx` is an index for `states` but does `first_row` have the same
index? Can they be different because `filtered_states` may have filtered rows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
