sunchao commented on code in PR #7565:
URL: https://github.com/apache/arrow-datafusion/pull/7565#discussion_r1327533823
##########
datafusion/physical-expr/src/aggregate/first_last.rs:
##########
@@ -550,4 +559,72 @@ mod tests {
assert_eq!(last_accumulator.evaluate()?, ScalarValue::Int64(Some(12)));
Ok(())
}
+
+ #[test]
+ fn test_first_last_state_after_merge() -> Result<()> {
+ let ranges: Vec<(i64, i64)> = vec![(0, 10), (1, 11), (2, 13)];
+ // create 3 ArrayRefs between each interval e.g from 0 to 9, 1 to 10,
2 to 12
+ let arrs = ranges
+ .into_iter()
+ .map(|(start, end)| {
+ Arc::new((start..end).collect::<Int64Array>())) as ArrayRef
+ })
+ .collect::<Vec<_>>();
+
+ // FirstValueAccumulator
+ let mut first_accumulator =
+ FirstValueAccumulator::try_new(&DataType::Int64, &[], vec![])?;
+
+ first_accumulator.update_batch(&[arrs[0].clone()])?;
+ let state1 = first_accumulator.state()?;
+
+ let mut first_accumulator =
+ FirstValueAccumulator::try_new(&DataType::Int64, &[], vec![])?;
+ first_accumulator.update_batch(&[arrs[1].clone()])?;
+ let state2 = first_accumulator.state()?;
+
+ assert_eq!(state1.len(), state2.len());
+
+ let mut states = vec![];
+
+ for idx in 0..state1.len() {
+ states.push(concat(&[&state1[idx].to_array(),
&state2[idx].to_array()])?);
+ }
+
+ let mut first_accumulator =
+ FirstValueAccumulator::try_new(&DataType::Int64, &[], vec![])?;
+ first_accumulator.merge_batch(&states)?;
+
+ let merged_state = first_accumulator.state()?;
+ assert_eq!(merged_state.len(), state1.len());
+
+ // LastValueAccumulator
Review Comment:
we probably can remove some common code here but not a blocker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
