matthewgapp commented on code in PR #7638:
URL: https://github.com/apache/arrow-datafusion/pull/7638#discussion_r1335254972
##########
datafusion/expr/src/window_function.rs:
##########
@@ -114,19 +114,35 @@ pub enum BuiltInWindowFunction {
impl BuiltInWindowFunction {
fn name(&self) -> &str {
- use BuiltInWindowFunction::*;
+ use BuiltInWindowFunction as F;
Review Comment:
flyby fix. Using wildcard here means that if a variant were deleted from the
enum, the bottom-most variant in the match statement would become a variable
catch-all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
