matthewgapp commented on code in PR #7638: URL: https://github.com/apache/arrow-datafusion/pull/7638#discussion_r1338752948
########## datafusion/sqllogictest/test_files/window.slt: ########## @@ -3315,3 +3315,23 @@ SELECT window1 AS (ORDER BY C3) ORDER BY C3 LIMIT 5 + +# Create table with window functions that have nullable: false columns should result in correct schema during cross join Review Comment: Note that starting with version 47.0.0 of Arrow, the tests referenced will no longer fail (without the fixes provided in this PR) because Arrow has stopped checking for schema nullability. For more context, visit [issue comment](https://github.com/apache/arrow-datafusion/issues/7636#issuecomment-1737225422). Therefore, I plan to introduce tests that explicitly check for nullable: false in the logical schema where it is expected, such as in columns created via row_number(), rank(), and similar functions. I will address this tonight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
