matthewgapp commented on code in PR #7638: URL: https://github.com/apache/arrow-datafusion/pull/7638#discussion_r1335314634
########## datafusion/sqllogictest/test_files/window.slt: ########## @@ -3315,3 +3315,23 @@ SELECT window1 AS (ORDER BY C3) ORDER BY C3 LIMIT 5 + +# Create table with window functions that have nullable: false columns should result in correct schema during cross join Review Comment: these tests fail on `main` ########## datafusion/sqllogictest/test_files/window.slt: ########## @@ -3315,3 +3315,23 @@ SELECT window1 AS (ORDER BY C3) ORDER BY C3 LIMIT 5 + +# Create table with window functions that have nullable: false columns should result in correct schema during cross join Review Comment: these tests fail on `main` but pass on this branch as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
