pitrou commented on code in PR #37822:
URL: https://github.com/apache/arrow/pull/37822#discussion_r1344275196


##########
python/setup.py:
##########
@@ -133,8 +143,68 @@ def run(self):
                       'bundle the Arrow C++ headers')] +
                     _build_ext.user_options)
 
+    def get_arrow_build_options(self):

Review Comment:
   I have to say I find this solution quite horrible. Enabling or disabling 
PyArrow components manually is a bit cumbersome, but not terribly so. If 
there's no better way to query Arrow CMake arguments than parsing some adhoc 
output format from a hidden CMake option, then I would rather not have this.
   
   @kou Any thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to