pitrou commented on code in PR #37822:
URL: https://github.com/apache/arrow/pull/37822#discussion_r1344280632
##########
python/CMakeLists.txt:
##########
@@ -570,28 +605,42 @@ endif()
# Acero
if(PYARROW_BUILD_ACERO)
- if(PYARROW_BUNDLE_ARROW_CPP)
- bundle_arrow_lib(${ARROW_ACERO_SHARED_LIB} SO_VERSION ${ARROW_SO_VERSION})
- if(MSVC)
- bundle_arrow_import_lib(${ARROW_ACERO_IMPORT_LIB})
+ if(ARROW_BUILD_SHARED)
+
+ if(PYARROW_BUNDLE_ARROW_CPP)
+ bundle_arrow_lib(${ARROW_ACERO_SHARED_LIB} SO_VERSION
${ARROW_SO_VERSION})
+ if(MSVC)
+ bundle_arrow_import_lib(${ARROW_ACERO_IMPORT_LIB})
+ endif()
endif()
- endif()
- set(ACERO_LINK_LIBS ArrowAcero::arrow_acero_shared)
- list(APPEND CYTHON_EXTENSIONS _acero)
+ set(ACERO_LINK_LIBS ArrowAcero::arrow_acero_shared)
+ list(APPEND CYTHON_EXTENSIONS _acero)
+ else()
+ # ACERO is statically linked into libarrow_python already
+ set(ACERO_LINK_LIBS)
+ list(APPEND CYTHON_EXTENSIONS _acero)
+ endif()
endif()
# Dataset
if(PYARROW_BUILD_DATASET)
- if(PYARROW_BUNDLE_ARROW_CPP)
- bundle_arrow_lib(${ARROW_DATASET_SHARED_LIB} SO_VERSION
${ARROW_SO_VERSION})
- if(MSVC)
- bundle_arrow_import_lib(${ARROW_DATASET_IMPORT_LIB})
+ if(ARROW_BUILD_SHARED)
+
+ if(PYARROW_BUNDLE_ARROW_CPP)
+ bundle_arrow_lib(${ARROW_DATASET_SHARED_LIB} SO_VERSION
${ARROW_SO_VERSION})
+ if(MSVC)
+ bundle_arrow_import_lib(${ARROW_DATASET_IMPORT_LIB})
+ endif()
endif()
- endif()
- set(DATASET_LINK_LIBS ArrowDataset::arrow_dataset_shared)
+ set(DATASET_LINK_LIBS ArrowDataset::arrow_dataset_shared)
+ else()
+ # dataset is sttically linked into libarrow_python already
Review Comment:
```suggestion
# dataset is statically linked into libarrow_python already
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
