alamb commented on code in PR #7727:
URL: https://github.com/apache/arrow-datafusion/pull/7727#discussion_r1346300290
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -285,7 +285,9 @@ pub struct AggregateExec {
schema: SchemaRef,
/// Input schema before any aggregation is applied. For partial aggregate
this will be the
/// same as input.schema() but for the final aggregate it will be the same
as the input
- /// to the partial aggregate
+ /// to the partial aggregate, i.e., partial and final aggregates have same
`input_schema`.
Review Comment:
🤔 I went to double check this (being inspired by the thoroughness of your
own reviews @viirya ) and I was able to remove the entire field:
https://github.com/apache/arrow-datafusion/pull/7741
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -285,7 +285,9 @@ pub struct AggregateExec {
schema: SchemaRef,
/// Input schema before any aggregation is applied. For partial aggregate
this will be the
/// same as input.schema() but for the final aggregate it will be the same
as the input
- /// to the partial aggregate
+ /// to the partial aggregate, i.e., partial and final aggregates have same
`input_schema`.
Review Comment:
🤔 I went to double check this (being inspired by the thoroughness of your
own reviews @viirya ) and I was able to remove the entire field:
https://github.com/apache/arrow-datafusion/pull/7741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
